-
-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add menus for top and bottom actions #4314
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix getting multiple cards from the bottom note that moving cards from the bottom of the deck does not get remembered by or disrupt undoing draws
tooomm
reviewed
Apr 16, 2021
tooomm
reviewed
Apr 16, 2021
tooomm
reviewed
Apr 16, 2021
tooomm
reviewed
Apr 16, 2021
Had a quick first look at the UI. Thanks for fixing the local games, ebbit! ;) |
Co-authored-by: tooomm <tooomm@users.noreply.github.com>
you're welcome, as long as you realize I added this bug too (and noone else even noticed for a month?) |
ZeldaZach
approved these changes
Apr 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Ticket(s)
Short roundup of the initial problem
there are no shortcuts or menu actions for interacting with the bottom card of the library
What will change with this Pull Request?
currently doesn't even work and just flat out breaks the player, for no reason?fixed #4315