Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add menus for top and bottom actions #4314

Merged
merged 5 commits into from
Apr 16, 2021

Conversation

ebbit1q
Copy link
Member

@ebbit1q ebbit1q commented Apr 15, 2021

Related Ticket(s)

Short roundup of the initial problem

there are no shortcuts or menu actions for interacting with the bottom card of the library

What will change with this Pull Request?

  • add two menu subentries, one for the top and one for the bottom
  • add every action available to the top of library to the bottom of library

currently doesn't even work and just flat out breaks the player, for no reason? fixed #4315

@ebbit1q ebbit1q marked this pull request as ready for review April 15, 2021 05:04
fix getting multiple cards from the bottom
note that moving cards from the bottom of the deck does not get
remembered by or disrupt undoing draws
cockatrice/src/player.cpp Outdated Show resolved Hide resolved
cockatrice/src/player.cpp Outdated Show resolved Hide resolved
cockatrice/src/player.cpp Outdated Show resolved Hide resolved
cockatrice/src/player.cpp Outdated Show resolved Hide resolved
@tooomm
Copy link
Member

tooomm commented Apr 16, 2021

Had a quick first look at the UI.

Thanks for fixing the local games, ebbit! ;)

Co-authored-by: tooomm <tooomm@users.noreply.github.com>
@ebbit1q
Copy link
Member Author

ebbit1q commented Apr 16, 2021

you're welcome, as long as you realize I added this bug too (and noone else even noticed for a month?)

@ZeldaZach ZeldaZach merged commit ad0f313 into Cockatrice:master Apr 16, 2021
@ebbit1q ebbit1q deleted the bottom_actions branch May 2, 2021 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

allow manipulation of bottom cards of library through actions
3 participants