Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes all library views when shuffled (#4261) #4324

Merged
merged 6 commits into from
Jun 2, 2021

Conversation

marsnicholas
Copy link
Contributor

Related Ticket(s)

Short roundup of the initial problem

Library views would be invalidated when a player shuffled

What will change with this Pull Request?

The library views will be closed on when the library is shuffled

@ebbit1q ebbit1q self-requested a review April 26, 2021 00:58
Copy link
Member

@ebbit1q ebbit1q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works as intended.

does not send the close message to the server, this message is pointless anyway as clients can send this message whenever they'd like (I'm going to remove it)

all views are closed when cards that aren't viewed are randomized, this is less than ideal but not a dealbreaker but it should be possible to check which cards are viewed and which cards are being shuffled at that moment. (clients shuffle parts of their library when they move cards to the bottom of their library in a random order)

@tooomm
Copy link
Member

tooomm commented Apr 26, 2021

Does it make sense to add e.g. '.vc' to the gitignore file to prevent local detection?

@ebbit1q
Copy link
Member

ebbit1q commented Apr 26, 2021

Does it make sense to add e.g. '.vc' to the gitignore file to prevent local detection?

yes, I asked them to do so through discord

@ZeldaZach ZeldaZach merged commit b858e36 into Cockatrice:master Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shuffling invalidates all views but doesn't notify them
4 participants