add option to delete a user's messages #4362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is ready for TESTING, please TEST this feature before merging it |
ZeldaZach
reviewed
Jun 2, 2021
| #include <QTextEdit> | ||
|
|
||
| const QColor DEFAULT_MENTION_COLOR = QColor(194, 31, 47); | ||
|
|
||
| UserMessagePosition::UserMessagePosition(QTextCursor &cursor) | ||
| { |
There was a problem hiding this comment.
What does this function do? I'm confused
There was a problem hiding this comment.
it's the constructor for the message position, it saves the block and the position in the block it references
ZeldaZach
reviewed
Jun 2, 2021
| UserLevelFlags userLevel, | ||
| QString UserPrivLevel, | ||
| bool playerBold) | ||
| { | ||
| bool atBottom = verticalScrollBar()->value() >= verticalScrollBar()->maximum(); | ||
| bool sameSender = (sender == lastSender) && !lastSender.isEmpty(); | ||
| // messageType should be Event_RoomSay::UserMessage though we don't actually check | ||
| bool isUserMessage = !(userName.toLower() == "servatrice" || userName.isEmpty()); |
There was a problem hiding this comment.
double hardcoded name, make into a const
There was a problem hiding this comment.
I don't like this name to begin with, I wanted to leave this check as similar as possible, when is "servatrice" talking anyway? only when the user talks or will it actually set it to servatrice otherwise?
ZeldaZach
reviewed
Jun 2, 2021
|
|
||
| // timestamp | ||
| if (showTimestamps && (!sameSender || sender.toLower() == "servatrice") && !sender.isEmpty()) { | ||
| if (showTimestamps && ((!sameSender && isUserMessage) || userName.toLower() == "servatrice")) { |
There was a problem hiding this comment.
better comments, i don't understand this
There was a problem hiding this comment.
it's better than the previous check
ZeldaZach
reviewed
Jun 2, 2021
| bool removedLastMessage = false; | ||
| QTextCursor cursor(document()); | ||
| for (; !messagePositions.isEmpty() && amount != 0; --amount) { | ||
| auto position = messagePositions.takeLast(); // go backwards from last message |
There was a problem hiding this comment.
and? qt's cursor for document editing is trash?
ZeldaZach
reviewed
Jun 2, 2021
ZeldaZach
reviewed
Jun 2, 2021
ZeldaZach
reviewed
Jun 2, 2021
add optional parameter remove_messages to the ban and warn commands add event for clients to redact messages implement server side command and message handling implement server history removal todo: client side implementation add option to remove messages to moderator action dialogs add storage of message beginnings to chatview add redactMessage command handle Event_RemoveMessages on rooms this approach is favored over parsing the chatroom after the fact but will use additional memory to store the block indexes this also leaves a problem in that user messages from the chat backlog are not removed in the same way because they don't have a user associated with them add workaround for old qt versions add action for users to remove messages from users in chats add chat history to userMessagePositions with regex proper const usage for userName allow removing the messages of unregistered users add menus to usernames in chat history this allows you to remove user messages on chat history as well this also allows moderators to take actions on users in chat history Apply suggestions from code review
ZeldaZach
approved these changes
Sep 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Ticket(s)
Short roundup of the initial problem
users say mean things sometimes and we'd like to forget that
What will change with this Pull Request?