Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add reset paths button to settings #4384

Merged
merged 1 commit into from
Sep 14, 2021
Merged

add reset paths button to settings #4384

merged 1 commit into from
Sep 14, 2021

Conversation

ebbit1q
Copy link
Member

@ebbit1q ebbit1q commented Jun 22, 2021

Related Ticket(s)

Short roundup of the initial problem

there is no option to restore the default settings in the client, short of deleting the settings directory

What will change with this Pull Request?

  • allow resetting paths and reloading database when needed
  • add a button to the settings
  • add a label to the settings that tells you it has been reset

Screenshots

image

ZeldaZach
ZeldaZach approved these changes Sep 14, 2021
View reviewed changes
Copy link
Member

@ZeldaZach ZeldaZach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I'd prefer to see individual path resets on each path, this does solve the issue at hand.

@ZeldaZach ZeldaZach merged commit c8bb8b0 into Cockatrice:master Sep 14, 2021
@ebbit1q ebbit1q deleted the reset_paths branch September 14, 2021 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeldaZach ZeldaZach ZeldaZach approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add "Restore default location" button for path settings.
2 participants
@ebbit1q @ZeldaZach