Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apply chat flood prevention in games next to rooms #4387

Merged
merged 2 commits into from
Jun 28, 2021

Conversation

ebbit1q
Copy link
Member

@ebbit1q ebbit1q commented Jun 27, 2021

users can send chat messages without any reasonable character limit to other users and in games, this will instead make it follow the same rules as the main rooms (1000 chars/10 seconds is the default)
this limit is shared over all games and all chat rooms and all their private messages at the same time and isn't very high, but this will stop users from sending too much text quite effectively.
this will sidestep the major performance complications associated with the way we parse for trigger words.

@ebbit1q
Copy link
Member Author

ebbit1q commented Jun 27, 2021

mac debug builds seem to be hitting a similar issue to the 20.04 ubuntu builds where they are using a version of protobuf that triggers the unused parameter waruning https://github.com/Cockatrice/Cockatrice/runs/2927119377#step:8:322
this warning can be safely ignored but it's in a header file and we don't want to ignore the warning in the rest of the project

@ZeldaZach ZeldaZach merged commit 0280fea into Cockatrice:master Jun 28, 2021
@ebbit1q ebbit1q deleted the prevent_chat_flooding_in_games branch June 28, 2021 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants