remove all instances of the type long #4519
Conversation
the long type has different sizes across operating systems and should not be used in the timeline an overflow could occur if the width in pixels multiplied by the total amount of milliseconds in the replay is larger than 2^31 which is easy enough considering with only 500 pixels width you'll reach this number with only 1.2 hours of replay (about 4 million millis), note that this would be windows exclusive as *nix uses 64 bits ~~qt-json's own repo suggests using qt5's implementation instead, testing revealed this is quite a bit faster, contrary to Cockatrice#3480~~ testing proved this to not be compatible with older qt versions servatrice uses the qthread usleep function which used to be protected but is now public cockatrice is not compatible with qt4 and hasn't been for a while
|
after further investigation in became clear that the changes to oracle would not be compatible with older versions of qt, I have split them into a separate branch for now: master...ebbit1q:removeqtjson |
|
I also made a conditional version master...ebbit1q:conditionallyremoveqtjson |
|
@n21lv confirmed that this fixed the issue |
|
I want to talk more about this, will DM you |
Shouldn't the QJson Classes be available starting with Qt 5.0? |
|
they can't handle our file sizes, only 5.15 can |
|
I see. Our Debian and Ubuntu are the only ones not using 5.15 yet. |
|
ubuntu 21.04 is not an lts release, current lts is 20.04 |
|
we should start packaging for debian 11 |
You are right. The releases in April (even years) are the LTS ones, not the uneven. 🙈 |
|
this is a very simple change, can we merge this so we can make the next beta |
what do you still need? |
Related Ticket(s)
Short roundup of the initial problem
the long type has different sizes across operating systems and should
not be used
What will change with this Pull Request?
in the timeline an overflow could occur if the width in pixels
multiplied by the total amount of milliseconds in the replay is larger
than 2^31 which is easy enough considering with only 500 pixels width
you'll reach this number with only 1.2 hours of replay (about 4 million
millis), note that this would be windows exclusive as *nix uses 64 bits
qt-json's own repo suggests using qt5's implementation instead, testing
revealed this is quite a bit faster, contrary to #3480
servatrice uses the qthread usleep function which used to be protected
but is now public
cockatrice is not compatible with qt4 and hasn't been for a while