Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement max lengths for input dialogs that are sent to the server #4522

Merged
merged 7 commits into from
Jan 16, 2022
Merged

implement max lengths for input dialogs that are sent to the server #4522

merged 7 commits into from
Jan 16, 2022

Conversation

ebbit1q
Copy link
Member

@ebbit1q ebbit1q commented Jan 13, 2022

Short roundup of the initial problem

people can enter really long messages where they shouldn't ever need that much

What will change with this Pull Request?

  • add a shared header that contains some constants
  • add these constants as a max value to every dialog with info that is sent to the server
  • some refactors (this always happens doesn't it)

ZeldaZach
ZeldaZach approved these changes Jan 13, 2022
View reviewed changes
Copy link
Member

@ZeldaZach ZeldaZach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine

@ZeldaZach ZeldaZach merged commit 994704d into Cockatrice:master Jan 16, 2022
@ebbit1q ebbit1q deleted the maxstringsizes branch January 17, 2022 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeldaZach ZeldaZach ZeldaZach approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ebbit1q @ZeldaZach