Address macOS issue where right-clicking a username in the main chat #4523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…(or game chat) areas would pop up a seemingly empty user profile. This is because the resize event is overridden and doesn't actually attempt to resize based on the size hint of the dialog. Now that we're explicit with the call, this resize should be forced and have comparable results to popping up user profile from the user list.
ebbit1q
reviewed
Jan 15, 2022
ebbit1q
reviewed
Jan 15, 2022
ebbit1q
reviewed
Jan 15, 2022
ebbit1q
reviewed
Jan 15, 2022
|
wait, why do we do something like assigning SIXTY as a constant, like what |
tooomm
reviewed
Jan 15, 2022
cockatrice/src/userinfobox.cpp
Outdated
| const qint64 DAYS_IN_A_YEAR = 365; | ||
| const quint64 SIXTY = 60; | ||
| const quint64 HOURS_IN_A_DAY = 24; | ||
| const quint64 DAYS_IN_A_YEAR = 365; |
There was a problem hiding this comment.
wait, why do we do something like assigning SIXTY as a constant, like what
I assume the intention was to name it MINUTES_IN_AN_HOUR when looking at the other constant names.
|
I made a pr that will address this #4526 |
* use datetime for calculating account age make translating easier by using tr multiples automatically account for leap days
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…(or game chat) areas would pop up a seemingly empty user profile. This is because the resize event is overridden and doesn't actually attempt to resize based on the size hint of the dialog. Now that we're explicit with the call, this resize should be forced and have comparable results to popping up user profile from the user list.
Related Ticket(s)
Before:
After:
