-
-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement custom protobuf debug string creation #4532
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebbit1q
changed the title
implement custom protobuf debug log string creation
implement custom protobuf debug string creation
Jan 19, 2022
I changed the logging behavior a bit so it no longer adds so many backslashes:
|
ebbit1q
commented
Jan 31, 2022
ebbit1q
force-pushed
the
debug_pb_message
branch
from
February 2, 2022 01:02
59fc90c
to
aeeb122
Compare
ebbit1q
force-pushed
the
debug_pb_message
branch
from
February 16, 2022 16:05
aeeb122
to
566e726
Compare
ZeldaZach
approved these changes
Feb 22, 2022
ebbit1q
added a commit
that referenced
this pull request
Oct 2, 2023
this was implemented in #4532, removing this line makes this entire file pointless the original internal function this used has been placed in absl instead, this is why it no longer works in protobuf 23+ I've chosen to remove this small optimisation and instead go with the simpler solution, escaping the hard coded strings as well, see the code on protobuf's source for reference: https://github.com/protocolbuffers/protobuf/blob/81068e8e8cf00f25559112a562661064d59bfa87/src/google/protobuf/text_format.cc#L1648
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short roundup of the initial problem
cockatrice generates a lot of debug output, which is great, but some things should not be logged, namely passwords and lengthy pictures/decklists
What will change with this Pull Request?
example log: