Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: User info dialog updates #4533

Merged
merged 10 commits into from
Apr 2, 2023
Merged

UI: User info dialog updates #4533

merged 10 commits into from
Apr 2, 2023

Conversation

tooomm
Copy link
Member

@tooomm tooomm commented Jan 19, 2022

Related Ticket(s)

Short roundup of the initial problem

Alignment was mixed across various lines.

What will change with this Pull Request?

  • Reorder information to avoid alignment issues
  • Move user "level" icon in front of the user name
  • Flag icon a tiny bit smaller
  • Some reordering and updated names

Screenshots

  • before
    userinfo-old

  • after
    userinfo


Note: I think the new account creation date from #4526 looks a bit odd as is right now. 馃

@tooomm tooomm changed the title user info UI: User info dialog updates Jan 19, 2022
@tooomm tooomm marked this pull request as ready for review January 19, 2022 21:05
@ebbit1q
Copy link
Member

ebbit1q commented Jan 20, 2022

I do think the pawn is sorta part of the user level though, also I removed the hardcoded multiple from the user age part refer to #4120

@ZeldaZach
Copy link
Member

No objections to moving the pawn up by the username, looks neat. Would still like location to be 2nd tho

@tooomm
Copy link
Member Author

tooomm commented Jan 23, 2022

I do think the pawn is sorta part of the user level though

I guess one could argue the pawn as visual representation of a player with their role is closely connected to the player and his user name as well. It feels natural to me to have it like that - the creator is listed exactly like that in the list of games. Basically all occurrences of the player name have the pawn close by.
The text explanation should be there nonetheless of course.

Both ways of placement are fine I guess, but this way it help with the alignment issue.

No objections to moving the pawn up by the username, looks neat. Would still like location to be 2nd tho

I thought that might bring us in the same situation where there is an icon in one line with text below it and it would result in the same alignment issues this tries to circumvent.

Turns out, it looks ok as it's only one icon:
150208859-201725ad-2e3c-44d6-a5e9-3097f4afb64a vs. userinfo

I prefer the first one too now. :D


Another thing:
The resizing behavior of the avatar is unchanged and feels a bit weird, but I found no quick solution for it.

@ZeldaZach
Copy link
Member

Remind me to change the User level to be commas instead of bars, and to make DONATOR/VIP as capital case first then lowercase

@tooomm
Copy link
Member Author

tooomm commented Jan 23, 2022

Remind me to change the User level to be commas instead of bars, and to make DONATOR/VIP as capital case first then lowercase

The acronym VIP should stay all capital letters though.

@tooomm
Copy link
Member Author

tooomm commented Mar 4, 2022

@ZeldaZach Reminder

@tooomm
Copy link
Member Author

tooomm commented Apr 1, 2023

Remind me to change the User level to be commas instead of bars, and to make DONATOR/VIP as capital case first then lowercase

The acronym VIP should stay all capital letters though.

@ZeldaZach I think it's ok to put a second reminder after one year.

Anyways, this can be merged I guess?

@ZeldaZach ZeldaZach merged commit 304ed3c into master Apr 2, 2023
@ZeldaZach ZeldaZach deleted the tooomm-user_info2 branch April 2, 2023 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants