fix keepalive being multiplied in server timeout #4663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a timeout happened after the client not receiving anything for keepalive * keepalive * maxtimeout (5 * 5 * 10) seconds instead of what you'd expect, it now only uses keepalive once instead of twice this means it should now take 50 seconds to time out when disconnected
change time between pings to 3 from 5 seconds change timout to 5 from 10 repeats
|
I've decided to change it to 15 seconds instead, this means the server will be pinged almost twice as often now and the amount of times it will try is halved. we could change this distribution though. |
ZeldaZach
approved these changes
Sep 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short roundup of the initial problem
a timeout happened after the client not receiving anything for
keepalive * keepalive * maxtimeout(5 * 5 * 10) seconds instead of what you'd expect. seems to have been an oversight in #1313What will change with this Pull Request?
it now only uses keepalive once instead of twice, this means it should now take 50 seconds to time out when disconnected, we could also change the value of the max timeout (currently 10) to something like 6 to time out in 30 seconds instead.