-
-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added hint when drawing 0 cards #4697
Conversation
…er had no cards left to draw."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it should check first if there are actually no cards left in the library instead of assuming drawing zero means there are none left.
update log message to present tense Co-authored-by: ebbit1q <ebbit1q@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
excellent, thank you for your contribution!
Related Ticket(s)
Short roundup of the initial problem
When a player drew 0 cards it was unclear why
What will change with this Pull Request?
Screenshots