Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added hint when drawing 0 cards #4697

Merged
merged 7 commits into from
Oct 29, 2022
Merged

Added hint when drawing 0 cards #4697

merged 7 commits into from
Oct 29, 2022

Conversation

Tobyclark
Copy link
Contributor

Related Ticket(s)

Short roundup of the initial problem

When a player drew 0 cards it was unclear why

What will change with this Pull Request?

  • Logging a player drawing 0 cards will now result in the message "player had no cards left to draw."

Screenshots

Copy link
Member

@ebbit1q ebbit1q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should check first if there are actually no cards left in the library instead of assuming drawing zero means there are none left.

Tobyclark and others added 2 commits October 27, 2022 17:25
update log message to present tense

Co-authored-by: ebbit1q <ebbit1q@gmail.com>
Copy link
Member

@ebbit1q ebbit1q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

excellent, thank you for your contribution!

@ebbit1q ebbit1q merged commit 8e4ddf3 into Cockatrice:master Oct 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add hint to "draws 0 cards" message in log
2 participants