Fix #4706: don't replace ampersands when loading from plain text #4734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this is the wrong way to go about this, searching the db is one of the most expensive operations the application can do and I'd like to minimise it, instead of always searching the db every single time a replacement is done maybe just don't do the & replacement, perhaps do it after it searches for the name (see db guessCard which also does up to three db searches per card and mangles it a bit). |
ebbit1q
reviewed
Jan 29, 2023
| {{"Aether Adept", 1}, {"Fire // Ice", 2}, {"Pain // Suffering", 3}, {"Forest", 4}}, | ||
| {{"Aether Adept", 1}, | ||
| {"Fire // Ice", 2}, | ||
| {"Minsc & Boo, Timeless Heroes", 1}, |
There was a problem hiding this comment.
these used to go 1234, what have you done zach 🙃
ebbit1q
reviewed
Jan 29, 2023
ebbit1q
changed the title
ebbit1q
approved these changes
Jan 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested by loading in from clipboard