save sets dialog size #4791
Merged
save sets dialog size #4791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Btw, this was not an issue on 2.8.0 The result with your change seems ok for me and fixes the reported issue. However, changes to ordering (like clicking on a column header to sort) are saved right away now, and confirming/clicking on the button is no longer needed. |
|
I absolutely did not change the behavior of ordering, are you sure? |
|
I noticed what was happening, the header state includes the displayed sorting order, this might be a bit annoying. note that at no point this changed your actual saved sets order. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Ticket(s)
Manage sets...#4778Short roundup of the initial problem
the sets dialog can be resized wrong
What will change with this Pull Request?