Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remember user inputs after failed registration #4982 #4983

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Remember user inputs after failed registration #4982 #4983

wants to merge 6 commits into from

Commits on Jan 12, 2024

  1. Modify dlg register to accept optional arguments for previous registr… 

    …ation inputs (Cockatrice#4982)
    @candyapplecorn
    candyapplecorn committed Jan 12, 2024
    Configuration menu
    Copy the full SHA
    920fdf2 View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2024

  1. Updated formatting

    @candyapplecorn
    candyapplecorn committed Jan 13, 2024
    Configuration menu
    Copy the full SHA
    9d0c4be View commit details
    Browse the repository at this point in the history

  2. Made DlgRegister a friend class of AbstractClient so that it can 

    access user input in case registering to a server fails and the
user is sent back to the registration input dialogue again. This
saves the user the effort of re-typing everything, when presumably
only one thing is incorrect

Adds the feature requested from issue Cockatrice#4982

See Cockatrice#4983 for more information
    @candyapplecorn
    candyapplecorn committed Jan 13, 2024
    Configuration menu
    Copy the full SHA
    ddf8487 View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2024

  1. changed window_main to friend of DLGRegister; pass in args for RAII

    @candyapplecorn
    candyapplecorn committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    710f0ed View commit details
    Browse the repository at this point in the history

Commits on Feb 11, 2024

  1. Merge branch 'master' into pr/4983

    @tooomm
    tooomm committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    72a3c43 View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2024

  1. simply save values in mainwindow, remove friends

    @ebbit1q
    ebbit1q committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    853675f View commit details
    Browse the repository at this point in the history