Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add meta fields to GraphQL model definitions #151

Merged
merged 3 commits into from Aug 11, 2023
Merged

Add meta fields to GraphQL model definitions #151

merged 3 commits into from Aug 11, 2023

Conversation

filipmiik
Copy link
Contributor

@filipmiik filipmiik commented Aug 11, 2023

Fixes inconsistency in provided meta fields/properties between REST API and GraphQL API. Following properties are added to GraphQL model definitions:

  • _state (Collection, Singleton, Tree)
  • _o (Collection, Tree)
  • _mby (Collection, Singleton, Tree)
  • _cby (Collection, Singleton, Tree)
  • _pid (Tree)

Context: https://discourse.getcockpit.com/t/help-where-to-find-relations-when-getting-content-item-of-type-tree/2450/4

@aheinze
Copy link
Collaborator

aheinze commented Aug 11, 2023

Hi 👋

Thank you for the contribution. May I ask you to put the _o attribute to the tree related array. It is only available in tree models.

Thanks!

@filipmiik
Copy link
Contributor Author

Oh, sorry, thought it's available for all collections. Fixed :)

@aheinze aheinze merged commit b5c88b1 into Cockpit-HQ:develop Aug 11, 2023
2 checks passed
@aheinze
Copy link
Collaborator

aheinze commented Aug 11, 2023

Děkuji!

@filipmiik
Copy link
Contributor Author

Danke auch! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants