Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

swift 5 support #1043

Closed
3 tasks done
rickyzh opened this issue Feb 19, 2019 · 2 comments
Closed
3 tasks done

swift 5 support #1043

rickyzh opened this issue Feb 19, 2019 · 2 comments
Milestone
3.5.2

Comments

@rickyzh
Copy link
Contributor

rickyzh commented Feb 19, 2019

What's the plan to support Swift 5.0

New Issue Checklist

Issue Info

Info Value
Platform Name ios
Platform Version 12.0
CocoaLumberjack Version 3.4.2
Integration Method cocoapods
Xcode Version Xcode 10.2 beta
Repro rate all the time (100%)
Swift version 5.0

Issue Description and Steps

Please fill in the detailed description of the issue (full textual output of any stack trace, compiler error, ...) and the steps to reproduce the issue.

image

image
@ffried
Copy link
Member

ffried commented Feb 20, 2019

Fixed by #1044

@ffried ffried closed this as completed Feb 20, 2019
@bpoplauschi bpoplauschi added this to the 3.5.2 milestone Mar 17, 2019
@parrots
Copy link
Contributor

parrots commented Mar 25, 2019 •
edited
Loading

The above commit did not cover DDAssert.swift, which has similar compiler errors when compiling 3.5.2 on Xcode 10.2.

Screen Shot 2019-03-25 at 5 16 42 PM

@parrots parrots mentioned this issue Mar 25, 2019
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.5.2
Development

No branches or pull requests
4 participants
@bpoplauschi @parrots @ffried @rickyzh