Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build break in Swift 5, current fix also support previous version… #1044

Merged
merged 1 commit into from
Feb 20, 2019

Conversation

rickyzh
Copy link
Contributor

@rickyzh rickyzh commented Feb 20, 2019

… of swift

New Pull Request Checklist

  • I have read and understood the CONTRIBUTING guide

  • I have read the Documentation

  • I have searched for a similar pull request in the project and found none

  • I have updated this branch with the latest master to avoid conflicts (via merge from master or rebase)

  • I have added the required tests to prove the fix/feature I am adding

  • I have updated the documentation (if necessary)

  • I have run the tests and they pass

  • I have run the lint and it passes (pod lib lint)

This merge request fixes / refers to the following issues: ...

Pull Request Description

Fix build break in Swift 5, current fix also support previous versions, 90th lines in CocoaLumberjack.swift

@OSSPolice
Copy link

2 Warnings
⚠️ Any changes to library code should be reflected in the CHANGELOG. Please consider adding a note there about your change.
⚠️ The library files were changed, but the tests remained unmodified. Consider updating or adding to the tests to match the library changes.

Generated by 🚫 Danger

@codecov-io
Copy link

Codecov Report

Merging #1044 into master will increase coverage by 0.53%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1044      +/-   ##
==========================================
+ Coverage   36.82%   37.35%   +0.53%     
==========================================
  Files          27       27              
  Lines        3927     3927              
==========================================
+ Hits         1446     1467      +21     
+ Misses       2481     2460      -21
Impacted Files Coverage Δ
Classes/DDASLLogger.m 55.76% <0%> (+1.92%) ⬆️
Classes/DDOSLogger.m 74.28% <0%> (+57.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 838cb6b...087c97c. Read the comment docs.

@ffried ffried self-requested a review February 20, 2019 06:35
@ffried ffried merged commit d46f681 into CocoaLumberjack:master Feb 20, 2019
@ffried ffried mentioned this pull request Feb 20, 2019
3 tasks
@sushichop sushichop added this to the 3.5.2 milestone Feb 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants