Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set s.platform :ios, '5.0', :osx '10.7' in Podspec #116

Closed
rivera-ernesto opened this issue May 30, 2013 · 1 comment
Closed

Set s.platform :ios, '5.0', :osx '10.7' in Podspec #116

rivera-ernesto opened this issue May 30, 2013 · 1 comment

Comments

@rivera-ernesto
Copy link
Member

Following #73 and to address #132, the podspec should specify iOS 5.0 and OSX 10.7 as the min requirements to avoid accidentally installing CocoaLumberjack 1.6.x on projects that still support iOS 4.x.

Pod::Spec.new do |s|
  s.name     = 'CocoaLumberjack'
  # ...
  s.ios.platform = :ios, "5.0"
  s.osx.platform = :osx, "10.7"
  # ...
end

Also CocoaLumberjack pod specs 1.6.1 and 1.6.2 from the Cocoapods/Specs should be updated.
@rivera-ernesto rivera-ernesto mentioned this issue Aug 22, 2013
Closed
@rivera-ernesto rivera-ernesto mentioned this issue Sep 27, 2013
Closed
rivera-ernesto pushed a commit to rivera-ernesto/CocoaLumberjack that referenced this issue Oct 1, 2013
Add platform requirements to Podspec to close CocoaLumberjack#116
80f2b05
@rivera-ernesto rivera-ernesto mentioned this issue Oct 1, 2013
Closed
@rivera-ernesto rivera-ernesto mentioned this issue Oct 29, 2013
Merged
rivera-ernesto pushed a commit to rivera-ernesto/CocoaLumberjack that referenced this issue Nov 1, 2013
Update podspec
f0bee39 
Supersedes CocoaLumberjack#143.

* Deduce tag from Pod version.
* Fix `pod spec lint` warnings.
* Remove files not directly related to the static library (Benchmarking, Demos) as Pods normally do.
* Add platform requirements (CocoaLumberjack#116).
@rivera-ernesto rivera-ernesto mentioned this issue Nov 1, 2013
Merged
@bpoplauschi bpoplauschi mentioned this issue Nov 1, 2013
Closed
@bpoplauschi
Copy link
Member

#148 takes care of this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bpoplauschi @rivera-ernesto