DDFileLogger refactoring

[rivera-ernesto]

Seems like many issues need to be solved regarding DDFileLogger (#52, #55, #129, #153 and #155) that would need refactoring instead of simple patches.

Personally I use crash reporters combined with CocoaLumberjack loggers so I may not participate to actively.

Anyone up to the task?

[ratkins]

+1

[dvor]

I'll try to refactor and fix those issues in the nearest future.

[rivera-ernesto]

Nice.

You can make a pull request as soon as you have some commits, not to merge it but to have some feedback/help/cheers.

[dvor]

It was really hard to reproduce #153 and #155. I spent few hours before I realized that the bug isn't here already. :)

Bug was fixed with #177, those issues can be closed now. @an0 cheers.

[rivera-ernesto]

Yes, when reviewing that pull request I was wondering if it would fix some of those open issues too. But as I don't really log to files I wasn't sure.

Thank you!

[rivera-ernesto]

Thanks @dvor!

[rivera-ernesto]

If everything works fine we should release this by tomorrow as 1.6.5.

[dvor]

It works fine but it would be better if you guys test it.

[rivera-ernesto]

Sure.

[bpoplauschi]

@dvor Your contribution is much appreciated.