Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

DDFileLogger refactoring #157

Closed
rivera-ernesto opened this Issue · 10 comments

4 participants

@rivera-ernesto
Collaborator

Seems like many issues need to be solved regarding DDFileLogger (#52, #55, #129, #153 and #155) that would need refactoring instead of simple patches.

Personally I use crash reporters combined with CocoaLumberjack loggers so I may not participate to actively.

Anyone up to the task?

@ratkins

+1

@dvor
Collaborator

I'll try to refactor and fix those issues in the nearest future.

@rivera-ernesto
Collaborator

Nice.

You can make a pull request as soon as you have some commits, not to merge it but to have some feedback/help/cheers.

@dvor
Collaborator

It was really hard to reproduce #153 and #155. I spent few hours before I realized that the bug isn't here already. :)

Bug was fixed with #177, those issues can be closed now. @an0 cheers.

@rivera-ernesto
Collaborator

Yes, when reviewing that pull request I was wondering if it would fix some of those open issues too. But as I don't really log to files I wasn't sure.

Thank you!

@rivera-ernesto
Collaborator

Thanks @dvor!

@rivera-ernesto
Collaborator

If everything works fine we should release this by tomorrow as 1.6.5.

@dvor
Collaborator

It works fine but it would be better if you guys test it.

@rivera-ernesto
Collaborator

Sure.

@bpoplauschi
Collaborator

@dvor Your contribution is much appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.