Sync internal queues to prevent cleaning up log files too soon in tests #1053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lolgear
reviewed
Mar 14, 2019
lolgear
approved these changes
Mar 14, 2019
Codecov Report
@@ Coverage Diff @@
## master #1053 +/- ##
=========================================
- Coverage 39.33% 38.7% -0.63%
=========================================
Files 27 27
Lines 3991 3999 +8
=========================================
- Hits 1570 1548 -22
- Misses 2421 2451 +30
Continue to review full report at Codecov.
|
|
@ffried |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Pull Request Checklist
I have read and understood the CONTRIBUTING guide
I have read the Documentation
I have searched for a similar pull request in the project and found none
I have updated this branch with the latest master to avoid conflicts (via merge from master or rebase)
I have added the required tests to prove the fix/feature I am adding
I have updated the documentation (if necessary)
I have run the tests and they pass
I have run the lint and it passes (
pod lib lint)Pull Request Description
On the iOS simulator, we would have a race condition where test files would be cleaned up before the tested file logger was able to clean up after itself. This fixes this by syncing DDLog's queue and the file logger's queue before deleting the log files/.