Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace banned function(sprintf) with safe one(snprint) #1057

Merged
merged 2 commits into from
Mar 19, 2019

Conversation

sushichop
Copy link
Member

New Pull Request Checklist

  • I have read and understood the CONTRIBUTING guide

  • I have read the Documentation

  • I have searched for a similar pull request in the project and found none

  • I have updated this branch with the latest master to avoid conflicts (via merge from master or rebase)

  • I have added the required tests to prove the fix/feature I am adding

  • I have updated the documentation (if necessary)

  • I have run the tests and they pass

  • I have run the lint and it passes (pod lib lint)

This merge request fixes / refers to the following issues: #1050 #1056

Pull Request Description

Replace one more banned function(sprintf) with safe one(snprint).
According to the code of #1050, I think sprintf should be also replaced.

@sushichop sushichop requested a review from ffried March 19, 2019 14:46
Copy link
Member

@ffried ffried left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, good catch. I searched for sprintf, but somehow missed that one.

@OSSPolice
Copy link

1 Warning
⚠️ The library files were changed, but the tests remained unmodified. Consider updating or adding to the tests to match the library changes.

Generated by 🚫 Danger

@codecov-io
Copy link

Codecov Report

Merging #1057 into master will increase coverage by 0.99%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1057      +/-   ##
==========================================
+ Coverage   38.37%   39.37%   +0.99%     
==========================================
  Files          27       27              
  Lines        4018     4018              
==========================================
+ Hits         1542     1582      +40     
+ Misses       2476     2436      -40
Impacted Files Coverage Δ
Classes/DDASLLogCapture.m 0% <ø> (ø) ⬆️
Tests/Tests/DDAtomicCounterTests.m 100% <0%> (+1.85%) ⬆️
Classes/DDASLLogger.m 50% <0%> (+36.53%) ⬆️
Classes/DDOSLogger.m 57.69% <0%> (+38.46%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f6f590...cf35a6d. Read the comment docs.

@ffried ffried merged commit 4d67e5c into CocoaLumberjack:master Mar 19, 2019
@sushichop sushichop deleted the PR/imporve-banned-fuc branch March 19, 2019 15:19
@bpoplauschi bpoplauschi added this to the 3.5.3 milestone Apr 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants