Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix format string crash. #1066

Merged
merged 1 commit into from
Apr 10, 2019
Merged

Fix format string crash. #1066

merged 1 commit into from
Apr 10, 2019

Conversation

hhanesand
Copy link
Contributor

@hhanesand hhanesand commented Apr 9, 2019

Was seeing a BAD_ACCESS crash on one of my log statements because I was passing a string with a %@, and the NSAssert function expects a format string, not a literal.

Was seeing a strange BAD_ACCESS crash on one of my log statements, and this fixed it.
@OSSPolice
Copy link

2 Warnings
⚠️ Any changes to library code should be reflected in the CHANGELOG. Please consider adding a note there about your change.
⚠️ The library files were changed, but the tests remained unmodified. Consider updating or adding to the tests to match the library changes.

Generated by 🚫 Danger

@codecov-io
Copy link

Codecov Report

Merging #1066 into master will increase coverage by 0.58%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1066      +/-   ##
=========================================
+ Coverage   37.52%   38.1%   +0.58%     
=========================================
  Files          27      27              
  Lines        3944    3944              
=========================================
+ Hits         1480    1503      +23     
+ Misses       2464    2441      -23
Impacted Files Coverage Δ
Classes/DDFileLogger.m 57.16% <0%> (+0.26%) ⬆️
Classes/DDOSLogger.m 61.53% <0%> (+40.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 073a2a0...5fcd4c0. Read the comment docs.

Copy link
Member

@sushichop sushichop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

@sushichop sushichop added this to the 3.5.3 milestone Apr 10, 2019
@ffried ffried merged commit 98f18d8 into master Apr 10, 2019
@ffried ffried deleted the hhanesand-patch-1 branch April 10, 2019 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants