Data Collection Practices

[bpoplauschi]

New Pull Request Checklist

• I have read and understood the CONTRIBUTING guide
• I have read the Documentation
• I have searched for a similar pull request in the project and found none

This merge request fixes / refers to the following issues: #1187

Pull Request Description

Add README section for the Data Collection Practices

[bpoplauschi]

@CocoaLumberjack/collaborators let's see some opinions here on how we can add more value to our framework's users with this section of the docs.

[codecov]

Codecov Report

Merging #1191 (823acdc) into master (48c2b96) will decrease coverage by 0.17%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1191      +/-   ##
==========================================
- Coverage   46.40%   46.23%   -0.18%     
==========================================
  Files          29       29              
  Lines        4663     4663              
==========================================
- Hits         2164     2156       -8     
- Misses       2499     2507       +8     

Impacted Files	Coverage Δ
Sources/CocoaLumberjack/DDOSLogger.m	65.21% <0.00%> (-17.40%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48c2b96...823acdc. Read the comment docs.

[sushichop]

Great work! IMO, this is enough👍

[bpoplauschi]

Cool @sushichop, thanks for looking into this.
I would like to also get @ffried's opinion before merging, just to be on the safe side :)

[sushichop]

@bpoplauschi

I would like to also get @ffried's opinion before merging, just to be on the safe side :)

I feel the same way🙂

[bpoplauschi]

@sushichop I just wanted both your opinions before merging ;)

[sushichop]

@bpoplauschi

@sushichop I just wanted both your opinions before merging ;)

Yeah, Thanks. Let's wait for a response🙂

[ffried]

Looks good in general. 👍
Just found two superfluous whitespaces and suggested a small re-phrasing of one sentence.

[lolgear]

@bpoplauschi
Am I right that you said about "docs" in related issue, but this PR only affects Readme.
Not sure if Readme is a document that is convenient for app developers.
Should we add additional document about data collection?

[bpoplauschi]

@ffried thanks for taking a look, I agree with your suggestions and have fixed those in a commit.
@lolgear once this PR is merged, I will regenerate the doc on https://cocoalumberjack.github.io which includes the content from our Readme, so that will also live on our documentation main page. I think this is enough.