Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add consistent newline to file endings #1272

Merged
merged 2 commits into from Dec 23, 2021
Merged

Conversation

fdenzer
Copy link

@fdenzer fdenzer commented Dec 23, 2021

New Pull Request Checklist

  • I have read and understood the CONTRIBUTING guide

  • I have read the Documentation

  • I have searched for a similar pull request in the project and found none

  • I have updated this branch with the latest master to avoid conflicts (via merge from master or rebase)

  • I have added the required tests to prove the fix/feature I am adding

  • I have updated the documentation (if necessary)

  • I have run the tests and they pass

  • I have run the lint and it passes (pod lib lint)

This merge request fixes / refers to the following issues: ...

Pull Request Description

Fixes #1034

Via running:
for x in $(find . -type f); do if [ -n "$(tail -c 1 <"$x")" ]; then echo >>"$x"; fi; done

I am not sure, if every png needs to end w/ newline, though.

@codecov
Copy link

codecov bot commented Dec 23, 2021

Codecov Report

Merging #1272 (e072130) into master (80ada1f) will increase coverage by 0.19%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1272      +/-   ##
==========================================
+ Coverage   47.58%   47.77%   +0.19%     
==========================================
  Files          32       32              
  Lines        5174     5174              
  Branches      484      484              
==========================================
+ Hits         2462     2472      +10     
+ Misses       2540     2536       -4     
+ Partials      172      166       -6     
Impacted Files Coverage Δ
Sources/CocoaLumberjack/DDOSLogger.m 69.49% <0.00%> (+16.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80ada1f...e072130. Read the comment docs.

Copy link
Member

@ffried ffried left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this on!

I think we need to exclude a few files here:

  • binary files don't need to be updated (could even corrupt them):
    • with below's exceptions, this is just png files in this case
  • tool-generated files don't need to be updated:
    • everything inside .idea
    • everything inside a *.xcodeproj
    • everything inside a *.xcassets
    • everything inside a *.xcdatamodeld

@ffried ffried merged commit 70f04b1 into CocoaLumberjack:master Dec 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add missing newlines to the end of some files.
2 participants