Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catch exceptions in logMessage. #130

Merged
merged 1 commit into from
Nov 1, 2013
Merged

Catch exceptions in logMessage. #130

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions Lumberjack/DDFileLogger.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -846,6 +846,7 @@ - (NSFileHandle *)currentLogFileHandle
#pragma mark DDLogger Protocol
////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////

static int exception_count = 0;
- (void)logMessage:(DDLogMessage *)logMessage
{
NSString *logMsg = logMessage->logMsg;
Expand All @@ -863,10 +864,20 @@ - (void)logMessage:(DDLogMessage *)logMessage
}

NSData *logData = [logMsg dataUsingEncoding:NSUTF8StringEncoding];

[[self currentLogFileHandle] writeData:logData];

[self maybeRollLogFileDueToSize];

@try {
[[self currentLogFileHandle] writeData:logData];

[self maybeRollLogFileDueToSize];
}
@catch (NSException *exception) {
exception_count++;
if (exception_count <= 10) {
NSLogError(@"DDFileLogger.logMessage: %@", exception);
if (exception_count == 10)
NSLogError(@"DDFileLogger.logMessage: Too many exceptions -- will not log any more of them.");
}
}
}
}

Expand Down