Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding missing 'void' in function declarations #1340

Merged
merged 1 commit into from
May 1, 2023

Conversation

LowAmmo
Copy link
Contributor

@LowAmmo LowAmmo commented May 1, 2023

  • Addresses a build warning in Xcode 14.3

New Pull Request Checklist


  • I have updated this branch with the latest master to avoid conflicts (via merge from master or rebase)
  • I have added the required tests to prove the fix/feature I am adding
  • I have updated the documentation (if necessary)
  • I have run the tests and they pass
  • I have run the lint and it passes (pod lib lint)

This merge request fixes / refers to the following issues: #1338

Pull Request Description

Add "void" to function declarations that take no arguments (seems to be a new standard with Xcode 14.3)

* Addresses a build warning in Xcode 14.3
@github-actions
Copy link

github-actions bot commented May 1, 2023

Warnings
⚠️ Any changes to library code should be reflected in the CHANGELOG. Please consider adding a note there about your change.
⚠️ The library files were changed, but the tests remained unmodified. Consider updating or adding to the tests to match the library changes.

Generated by 🚫 Danger Swift against 53e510a

Copy link
Member

@ffried ffried left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!
I don't think we have any backwards compatibility issues here. This should work for previous versions of Xcode as well.

@ffried ffried enabled auto-merge (rebase) May 1, 2023 14:45
@codecov
Copy link

codecov bot commented May 1, 2023

Codecov Report

Merging #1340 (53e510a) into master (3bd7b2f) will decrease coverage by 0.41%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master    #1340      +/-   ##
==========================================
- Coverage   49.41%   49.00%   -0.41%     
==========================================
  Files          32       32              
  Lines        5304     5140     -164     
  Branches      481      455      -26     
==========================================
- Hits         2621     2519     -102     
+ Misses       2509     2443      -66     
- Partials      174      178       +4     
Impacted Files Coverage Δ
Sources/CocoaLumberjack/DDFileLogger.m 50.85% <ø> (-3.19%) ⬇️
...ocoaLumberjack/Extensions/DDFileLogger+Buffering.m 73.21% <50.00%> (ø)

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ffried ffried merged commit cb050c6 into CocoaLumberjack:master May 1, 2023
46 of 47 checks passed
@LowAmmo LowAmmo deleted the Issue-1338-compile-warnings branch May 1, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Compile Time Warnings about "a function declaration without a prototype is deprecated"
2 participants