Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop older Swift version (<5.8), Bump deployment targets to support minimums #1416

Merged
merged 2 commits into from Apr 16, 2024

Conversation

ffried
Copy link
Member

@ffried ffried commented Apr 16, 2024

New Pull Request Checklist


  • I have updated this branch with the latest master to avoid conflicts (via merge from master or rebase)
  • I have added the required tests to prove the fix/feature I am adding
  • I have updated the documentation (if necessary)
  • I have run the tests and they pass
  • I have run the lint and it passes (pod lib lint)

This merge request fixes / refers to the following issues: Fixes #1375, fixes #1404

Pull Request Description

  • Drops support for older Swift versions pre 5.8 (SPM will automatically fall back to older releases).
  • Bumps deployment targets to minimums supported by Xcode 15.

@ffried ffried mentioned this pull request Apr 16, 2024
8 tasks
@ffried ffried force-pushed the feature/xcode-swift-updates branch from 9a2de9a to 8d18208 Compare April 16, 2024 14:35
@ffried
Copy link
Member Author

ffried commented Apr 16, 2024

This also fixes #1375 since I bumped the minimum to watchOS 5.0...

Copy link

codecov bot commented Apr 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.17%. Comparing base (34f5901) to head (8d18208).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1416      +/-   ##
==========================================
+ Coverage   52.24%   56.17%   +3.92%     
==========================================
  Files          32       34       +2     
  Lines        4580     4840     +260     
  Branches      518      518              
==========================================
+ Hits         2393     2719     +326     
+ Misses       2187     2121      -66     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ffried ffried merged commit dc28b52 into master Apr 16, 2024
51 of 52 checks passed
@ffried ffried deleted the feature/xcode-swift-updates branch April 16, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant