DDTTYLogger: Allow to set default color profiles for all contexts at once #146
Conversation
…once * Using `LOG_CONTEXT_ALL` will associate a color profile log messages from all contexts. * Specific contexts can still set a different color profile on top.
| @@ -7,6 +7,8 @@ | |||
|
|
|||
| #import "DDLog.h" | |||
|
|
|||
| #define LOG_CONTEXT_ALL NSIntegerMax | |||
There was a problem hiding this comment.
Instead of declaring and additional LOG_CONTEXT_ALL a negative context value could be used.
There was a problem hiding this comment.
I think we should define a new constant/macro (I personally prefer constants because of the compiler can type check them).
There was a problem hiding this comment.
What about negative values? @robbiehanson ?
I like to have to remember as few constants as possible;)
|
@rivera-ernesto I think the pull request looks good, I will go ahead and merge it (unless you still need to work on this) |
|
Thinking more about it I think its better to keep the I think I would keep the pull request as it is now. |
…file_forcontexts DDTTYLogger: Allow to set default color profiles for all contexts at once
…lag: to LOG_CONTEXT_ALL Until now this method applied to only the default context `(0)`. Follows CocoaLumberjack#146.
LOG_CONTEXT_ALLwill associate a color profile log messages from all contexts.In the future
setForegroundColor:backgroundColor:forFlag:(int)maskcould set the value forLOG_CONTEXT_ALLinstead of context(0).