Use DISPATCH_CURRENT_QUEUE_LABEL if available #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check if DISPATCH_CURRENT_QUEUE_LABEL is defined.
|
Using DISPATCH_CURRENT_QUEUE_LABEL works only if the SDK is 7.0+ and the app is running under iOS 7.0+. Not equals "ascending" here means that the iOS version should be not less than 7.0. |
| else { | ||
| queueLabel = dd_str_copy(""); | ||
| } | ||
| #elif __IPHONE_OS_VERSION_MIN_REQUIRED >= 60000 |
There was a problem hiding this comment.
Maybe its cleaner to use __IPHONE_OS_VERSION_MIN_REQUIRED >= __IPHONE_6_0 here.
|
Thanks for the updates! Let's give a good test before releasing 1.6.3. |
rivera-ernesto
pushed a commit
that referenced
this pull request
Nov 7, 2013
Use DISPATCH_CURRENT_QUEUE_LABEL if available
rivera-ernesto
pushed a commit
to rivera-ernesto/CocoaLumberjack
that referenced
this pull request
Nov 8, 2013
No longer necessary after pull requests CocoaLumberjack#121 and CocoaLumberjack#156, and more importantly, that was ugly.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A better way to get current queue label on iOS 7.
Issue #108, Issue #121.