Fixing bugs in DDFileLogger #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| - (void)rollLogFile; | ||
| - (void)rollLogFileWithCompletion:(void (^)())completionBlock; |
There was a problem hiding this comment.
Maybe rollLogFileWithCompletionBlock: would be better?
Just a small detail, but as it is ugly to change the API later ;)
…' in DDFileLogger. 'rollLogFile' method is deprecated now. Completion block is optional and will be called on main queue.
…If file is moved/removed - rolling it and creating new one.
…ow we are setting appropriate NSFileProtectionKey (NSFileProtectionCompleteUntilFirstUserAuthentication if app is able launch from background and NSFileProtectionCompleteUnlessOpen in other cases).
rivera-ernesto
pushed a commit
that referenced
this pull request
Dec 2, 2013
Fixing bugs in DDFileLogger
This was referenced Dec 2, 2013
Closed
| @@ -49,6 +49,10 @@ - (void)maybeRollLogFileDueToSize; | |||
|
|
|||
| @end | |||
|
|
|||
| #if TARGET_OS_IPHONE | |||
| BOOL doesAppRunInBackground(void); | |||
There was a problem hiding this comment.
This should be static: unprefixed extern method is bound to cause a linker error :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for issues:
rollLogFileWithCompletion:,rollLogFilebecame deprecated.currentLogFileVnodeto monitor file descriptor, and if file gets moved or deleted - we are rolling it and create a new one.UPD
Issue #129 is also fixed. Setting appropriate
NSFileProtectionKeywhen creating log file on iOS.