Improve support for OS X command line tools #194
Conversation
Avoid relying in AppKit to check OS X version.
|
Looks good so far, I no longer see those two issues I mentioned at the top of #193 related to NSApp/NSApplication. Now the only failure is in DDTTYLogger due to not finding NSColor. The changes needed to break that hard dependency will likely be a lot more significant I'm betting, and I'm thinking I'd prefer to actually use DDTTYLogger (with color) more than I'm dreading having to link in AppKit (since the color formatting stuff looks awesome). So as far as I'm concerned I'm fine with just applying the changes you have here so that at least DDLog is no longer AppKit-dependent, meanwhile DDTTYLogger can continue requiring NSColor and hence AppKit. If I change my mind later I suppose I can just implement a custom TTY logger class that doesn't use NSColor. Thoughts? (And thanks for entertaining this idea in the first place) |
…don't link with AppKit
…umberjack_CLI is defined in Pods-environment.h
| s.subspec 'CLI' do |ss| | ||
| ss.dependency 'CocoaLumberjack/Core' | ||
| ss.source_files = 'Lumberjack/CLI/*.{h,m}' | ||
| end |
There was a problem hiding this comment.
New subspec for OS X projects that don't use AppKit.
|
Please @stmontgomery give this branch a try. |
| @@ -32,3 +32,6 @@ script: | |||
| - xctool -project Xcode/BenchmarkIPhone/BenchmarkIPhone.xcodeproj -scheme 'BenchmarkIPhone' -configuration Release -sdk iphonesimulator -arch i386 build | |||
| - xctool -project Xcode/Testing/TestXcodeColors/Desktop/TestXcodeColors.xcodeproj -scheme 'TestXcodeColors' | |||
| - xctool -project Xcode/UniversalApp/UniversalApp.xcodeproj -scheme 'UniversalApp' -configuration Release -sdk iphonesimulator -arch i386 build | |||
| - cd Xcode/CLI | |||
| - pod install | |||
| - xctool -workspace CLI.xcworkspace -scheme 'CLI' | |||
There was a problem hiding this comment.
Made sure not to break other usages.
|
This looks great so far, I've been on holiday but planning to try out this branch again soon |
|
I'm on holidays too ;) |
|
Apologies for the delay, but this looks great! I was able to build against this branch cleanly and I successfully un-linked AppKit.framework from OS X framework and no longer rely on NSColor. So I think this is good to go, thanks again! |
|
In this case, we could merge the pull request. @rivera-ernesto should I merge it? |
|
Cool. I've just came back from holidays as well. I think this is good to merge then. |
|
@rivera-ernesto great improvement! I'll merge it. |
Improve support for OS X command line tools
Following #193, in OS X linking against AppKit should be optional:
As for TTY logger need for NSColor, I think the solution would be to create a B/W or CLI-compatible TTY logger, which could be in turn the supper class of our current TTY logger.
Also a subspec
CocoaLumbjerack/CLIwould avoid compiling non-CLI-friendly code.Please give the branch a try and if you want you can ask for permissions to commit directly to it, as I don't actually develop much for OS X at the moment.