DDFileLogger: fixed crash that occured in case if application name == nil #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| return appName; | ||
| } |
There was a problem hiding this comment.
I think that for performance this method should be wrapped inside a dispatch_once block and store the value in a static _appName.
|
@rivera-ernesto this make sense, I've updated pull request. |
dvor
added a commit
to robbiehanson/CocoaAsyncSocket
that referenced
this pull request
Dec 26, 2013
|
Cool! |
rivera-ernesto
pushed a commit
that referenced
this pull request
Dec 27, 2013
DDFileLogger: fixed crash that occured in case if application name == nil
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #197
DDFileLogger was crashing in case if appName was equal to nil.