Issue217 read access to loggers #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Feature request from #217 |
| */ | ||
| + (NSArray *)allLoggers; | ||
| + (void)allLoggersOnQueue:(dispatch_queue_t)queue | ||
| withBlock:(void (^)(NSArray *loggers))block; |
There was a problem hiding this comment.
For simplicity and to make it easier to maintain in the future I think we should keep only the first method, and let client projects use the results in the queue they want with or without blocks:
|
I would agree with @rivera-ernesto about the simplicity. Do you see a particular reason to make it async besides syntactic sugar? |
|
No, I'll clean it up asap. |
|
It's easy for us to comment, you are doing the work :) |
|
Updated pull request. :) |
|
Looks good. Merging. And thanks @dvor |
bpoplauschi
added a commit
that referenced
this pull request
Feb 13, 2014
Issue217 read access to loggers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Providing read access to loggers:
+ (NSArray *)allLoggers;