Allow prevention of log file reuse. #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e a new log file at every app launch. Modification keeps backwards compatibility with existing code as it will maintain previous behavior if the reuseExistingLogFile property isn’t set.
| @@ -575,6 +575,7 @@ - (instancetype)initWithLogFileManager:(id <DDLogFileManager>)aLogFileManager | |||
| { | |||
| if ((self = [super init])) | |||
| { | |||
| _reuseLogFiles = TRUE; | |||
There was a problem hiding this comment.
If you change it into -> doNotReuseLogFiles this line won't be needed (default BOOL's are NO) and makes it the default value more intuitive to users by just looking at the property name.
There was a problem hiding this comment.
Updated according to your suggestions. Ready to pull.
| @@ -905,7 +905,7 @@ - (DDLogFileInfo *)currentLogFileInfo | |||
| { | |||
| DDLogFileInfo *mostRecentLogFileInfo = [sortedLogFileInfos objectAtIndex:0]; | |||
|
|
|||
| BOOL useExistingLogFile = YES; | |||
| BOOL useExistingLogFile = !_doNotReuseLogFiles; | |||
There was a problem hiding this comment.
useExistingLogFile is no longer necessary, just use doNotReuseLogFiles directly.
It will also make reading the code easier for those who will pass by later ;)
Thank you for updating!
| @@ -905,22 +905,18 @@ - (DDLogFileInfo *)currentLogFileInfo | |||
| { | |||
| DDLogFileInfo *mostRecentLogFileInfo = [sortedLogFileInfos objectAtIndex:0]; | |||
|
|
|||
| BOOL useExistingLogFile = YES; | |||
There was a problem hiding this comment.
Updated per your suggestion.
There was a problem hiding this comment.
Thanks a lot! Less code = easier to maintain.
rivera-ernesto
pushed a commit
that referenced
this pull request
Mar 12, 2014
Allow prevention of log file reuse.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is nice if you want to create a new log file at every app launch.
Modification keeps backwards compatibility with existing code as it will maintain previous behavior if the reuseExistingLogFile property isn’t set.