Check and log some errors. #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -329,6 +330,7 @@ - (void)backgroundThread_CompressLogFile:(DDLogFileInfo *)logFile | |||
| if (writeLength < 0) | |||
| { | |||
| error = YES; | |||
| streamError = [outputStream streamError]; | |||
There was a problem hiding this comment.
We could just remove error now and just check !streamError in the enclosing while condition.
|
Nice! |
|
Yes, you're right that we don't need both error and streamError. Let me re-submit this one -- I have another PR coming which will be impacted too. |
|
Thank you for all the pull requests. I'll try to leave the more sensitive ones however for @dvor . |
Log the streamError whenever we fail to write during compression, and log any failures when removing the original file or cleaning up the temporary file after compression failed.
|
Re-submitted. This version just uses a single NSError* error variable instead of the BOOL error and NSError* streamError. It also re-uses the NSError* in the cleanup instead of having a separate one. |
|
Thank you! |
rivera-ernesto
pushed a commit
that referenced
this pull request
Apr 1, 2014
…eam-error Check and log some errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Log the streamError whenever we fail to write during compression,
and log any failures when removing the original file or cleaning up
the temporary file after compression failed.