Replaced warnings when ARC was not enabled with errors #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ry that CocoaLumberjack is compiled with ARC enabled (even if only for the CL files using -f-objc-arc).
|
Looks ok. Next time you could try to supersede the previous pul request by following GitHub command line merge instructions to start with the previous pull request changes. |
rivera-ernesto
pushed a commit
that referenced
this pull request
May 19, 2014
Replaced warnings when ARC was not enabled with errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #281 and #282 (this pull request was not complete and the author did not respond in time).
It's mandatory that CocoaLumberjack is compiled with ARC enabled (even if only for the CL files using -f-objc-arc).