Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swift improvements #434

Merged

Conversation

MaddTheSane
Copy link
Contributor

These improvements help make the Swift additions to CocoaLumberjack behave better, as well as fixing some bugs.

@bpoplauschi
Copy link
Member

Looks good to me, but since I'm not yet a valid Swift practitioner, I will wait for @rivera-ernesto and @dvor to look at this PR. Anyway, @MaddTheSane thanks for working on this.

@rivera-ernesto
Copy link
Member

Looks good @MaddTheSane !

By the way would you like to be a maintainer? Just by looking over Swift compatibility would be enough. Off course you could participate in any issue/pull request and we would continue to take a look at Swift as well.

rivera-ernesto pushed a commit that referenced this pull request Jan 8, 2015
@rivera-ernesto rivera-ernesto merged commit bddc4a3 into CocoaLumberjack:master Jan 8, 2015
@MaddTheSane
Copy link
Contributor Author

I wouldn't mind being a maintainer, even if it is only over Swift code.

@MaddTheSane MaddTheSane deleted the swiftImprovements branch January 8, 2015 22:01
@rivera-ernesto
Copy link
Member

Perfect! @robbiehanson could you add @MaddTheSane as a maintainer?

@bpoplauschi
Copy link
Member

@robbiehanson could you respond to this, please?

@bpoplauschi
Copy link
Member

@robbiehanson hey man, could you help us out with this? We should bring this guy on board.

@rivera-ernesto
Copy link
Member

I don't think he gets any mentions' notification. We should try contacting him directly but I can't find a valid email address.

@robbiehanson
Copy link
Contributor

could you add @MaddTheSane as a maintainer?

Added.

@rivera-ernesto
Copy link
Member

Thanks @robbiehanson, it would be also good to have the permissions to freely add maintainers. I think GitHub has improved organization permissions, so you should be able to give us that permission while keeping owner privileges for yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants