-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swift improvements #434
Swift improvements #434
Conversation
Fix the reference to the Swift version's info.plist file.
This quiets a warning about an include that isn't in the umbrella header.
Make the comments for CurrentFileName and DDLogFlag.toLogLevel show up when compiled.
Looks good to me, but since I'm not yet a valid Swift practitioner, I will wait for @rivera-ernesto and @dvor to look at this PR. Anyway, @MaddTheSane thanks for working on this. |
Looks good @MaddTheSane ! By the way would you like to be a maintainer? Just by looking over Swift compatibility would be enough. Off course you could participate in any issue/pull request and we would continue to take a look at Swift as well. |
I wouldn't mind being a maintainer, even if it is only over Swift code. |
Perfect! @robbiehanson could you add @MaddTheSane as a maintainer? |
@robbiehanson could you respond to this, please? |
@robbiehanson hey man, could you help us out with this? We should bring this guy on board. |
I don't think he gets any mentions' notification. We should try contacting him directly but I can't find a valid email address. |
Added. |
Thanks @robbiehanson, it would be also good to have the permissions to freely add maintainers. I think GitHub has improved organization permissions, so you should be able to give us that permission while keeping owner privileges for yourself. |
These improvements help make the Swift additions to CocoaLumberjack behave better, as well as fixing some bugs.