Default ddLogLevel set to DDLogLevelVerbose #473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o start using CocoaLumberjack is clumsy.", we can define the global log level to Verbose unless it's already defined.
Closed
|
Good idea! |
rivera-ernesto
added a commit
that referenced
this pull request
Mar 10, 2015
…o_verbose Default ddLogLevel set to DDLogLevelVerbose
|
For Swift the global log level ist still set to .Warning instead of .Verbose public var defaultDebugLevel = DDLogLevel.Warning
public func resetDefaultDebugLevel() {
defaultDebugLevel = DDLogLevel.Warning
} |
|
Should we set it to Verbose, to make it consistent with the Objective-C default one? |
|
I think so. |
| @@ -24,7 +24,11 @@ | |||
| * The constant/variable/method responsible for controlling the current log level. | |||
| **/ | |||
| #ifndef LOG_LEVEL_DEF | |||
| #define LOG_LEVEL_DEF ddLogLevel | |||
| #ifdef ddLogLevel | |||
There was a problem hiding this comment.
Also noticed that this check never works as usually ddLogLevel is defined as a variable instead of a preprocessor #define.
bpoplauschi
added a commit
that referenced
this pull request
Jun 24, 2015
…it created more issues than solved.
ospr
added a commit
to ospr/CocoaLumberjack
that referenced
this pull request
Mar 9, 2016
… #ifdef ddLogLevel was a bad idea and it created more issues than solved." This reverts commit 932a65e.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid
we can define the global log level to Verbose unless it's already defined.