Use an absolute path to identify the modulemap. #518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some cases when adding CocoaLumberjack as a submodule, Xcode can get confused and attempts to find the modulemap file in the wrong directory (e.g. `Lumberjack/Mobile/CocoaLumberjack.modulemap`). I'm not sure why this happens, but using an absolute path (via `$PROJECT_DIR`) makes our intention more explicit and avoids this problem.
|
Hm. It appears that some Travis CI tests failed, but I don't see how those failures could be related to the changes in this commit. Is the |
|
Yes, they are nor related. Unit Tests are broken because of a race condition. |
rivera-ernesto
added a commit
that referenced
this pull request
May 25, 2015
Use an absolute path to identify the modulemap.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases when adding CocoaLumberjack as a submodule, Xcode can get confused and attempts to find the modulemap file in the wrong directory (e.g.
Mobile/Lumberjack/CocoaLumberjack.modulemap, which does not exist). I'm not sure why happens or in exactly which situations, but using an absolute path (via$PROJECT_DIR) makes our intention more explicit and avoids this problem.