Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add armv7s to static library #538

Merged
merged 1 commit into from
Jun 23, 2015
Merged

Add armv7s to static library #538

merged 1 commit into from
Jun 23, 2015

Conversation

nrbrook
Copy link
Contributor

@nrbrook nrbrook commented Jun 23, 2015

I'm using Cocoa Lumberjack in a static framework distributed to other developers. I want to include armv7s in that framework in case developers want to use armv7s in their own Apps. However, the standard architectures in Xcode 6 and up don't include armv7s, and so the Cocoa Lumberjack targets don't compile for it.

For the dynamic framework the extra architecture consumes more space in the App bundle (750 KB vs 533 KB without), but for the static library I don't think there is any argument against including it as it will be stripped from the final App if not needed.

In this pull request I've just added armv7s to the static library target.

For the dynamic framework the extra architecture consumes more space in the App bundle (750 KB vs 533 KB without), but for the static library I don't think there is any argument against including it as it will be stripped from the final App if not needed.
@rivera-ernesto
Copy link
Member

Is this something that will get added by default with Xcode 7? If so you better switch to our swift_2.0 branch instead.

@nrbrook
Copy link
Contributor Author

nrbrook commented Jun 23, 2015

No, this is unrelated to Xcode 7. Xcode 7 is no different to 6 in this respect.

@rivera-ernesto
Copy link
Member

Then why isn't armv7s part of ARCHS_STANDARD? I would prefer to keep default values as much as possible.

@nrbrook
Copy link
Contributor Author

nrbrook commented Jun 23, 2015

From Apple dev forums

The reason for including armv7s would be marginal backward compatibility. But the general differences between armv7 and armv7s instruction sets are minor. So if you choose not to include armv7s, the targeted armv7 machine code still runs fine on 32 bit A6 devices, and hardly one will notice performance gap.

Developers have requested that I provide armv7s in the framework I produce, and to do that I also need Cocoa Lumberjack to compile armv7s. There is no reason not to, other than it not being the default value (but it includes the default values)

@nrbrook
Copy link
Contributor Author

nrbrook commented Jun 23, 2015

If you don't want to merge, I will just do a fork for my own needs.

@rivera-ernesto
Copy link
Member

I see. Weird decision from Apple.
As you say including more slices in a library has nothing wrong at all.

rivera-ernesto added a commit that referenced this pull request Jun 23, 2015
Add armv7s to static library
@rivera-ernesto rivera-ernesto merged commit 2c5aebe into CocoaLumberjack:master Jun 23, 2015
@nrbrook
Copy link
Contributor Author

nrbrook commented Jun 23, 2015

Think it's so App binaries are smaller so download quicker. For libraries it's a different matter. Cheers!

@bpoplauschi bpoplauschi added this to the 2.0.1 milestone Jun 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants