Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using Cocoa Lumberjack in a static framework distributed to other developers. I want to include armv7s in that framework in case developers want to use armv7s in their own Apps. However, the standard architectures in Xcode 6 and up don't include armv7s, and so the Cocoa Lumberjack targets don't compile for it.
For the dynamic framework the extra architecture consumes more space in the App bundle (750 KB vs 533 KB without), but for the static library I don't think there is any argument against including it as it will be stripped from the final App if not needed.
In this pull request I've just added armv7s to the static library target.