Add tvOS targets on project #605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvOS does not support `host_info()` anymore. At the same time it supports `[[NSProcessInfo processInfo] activeProcessorCount]` so this can be used instead.
Mac OS before 10.5 would not support [NSProcessInfo processorCount] so make this safe.
| @@ -875,6 +866,13 @@ @implementation DDLogMessage | |||
| #define USE_DISPATCH_CURRENT_QUEUE_LABEL YES | |||
| #define USE_DISPATCH_GET_CURRENT_QUEUE YES | |||
|
|
|||
| #elif TARGET_OS_TV | |||
There was a problem hiding this comment.
Maybe it would be cool better to merge these conditions as #if TARGET_OS_IOS || TARGET_OS_WATCH.
|
You mean like this (f6ce2ed)? |
|
Yes, specially since both platforms share the same behavior. |
rivera-ernesto
added a commit
that referenced
this pull request
Oct 6, 2015
Add tvOS targets on project
|
We may need to create a separate branch for this one following #609. |
This was referenced Oct 7, 2015
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow include tvOS frameworks on projects, and let Carthage build tvOS framework.