Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-add NS_DESIGNATED_INITIALIZER #619

Merged
merged 1 commit into from
Oct 13, 2015
Merged

Re-add NS_DESIGNATED_INITIALIZER #619

merged 1 commit into from
Oct 13, 2015

Conversation

sinoru
Copy link
Contributor

@sinoru sinoru commented Oct 13, 2015

I found that one NS_DESIGNATED_INITIALIZER removed, so re-added it.

@bpoplauschi bpoplauschi added this to the 2.1.0 - Swift milestone Oct 13, 2015
bpoplauschi added a commit that referenced this pull request Oct 13, 2015
@bpoplauschi
Merge pull request #619 from sinoru/mark-NS_DESIGNATED_INITIALIZER
97feaec 
Re-add NS_DESIGNATED_INITIALIZER
@bpoplauschi bpoplauschi merged commit 97feaec into CocoaLumberjack:master Oct 13, 2015
@rivera-ernesto
Copy link
Member

There's another approach by @sinoru that involves using - (instancetype)init NS_UNAVAILABLE. We should choose one or the other and stuck with it.

@bpoplauschi
Copy link
Member

I missed that. Too many changes I guess :)

@sinoru sinoru deleted the mark-NS_DESIGNATED_INITIALIZER branch October 23, 2015 06:32
@rivera-ernesto rivera-ernesto mentioned this pull request Oct 23, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sinoru @rivera-ernesto @bpoplauschi