Fix NSDateFormatter issues #621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stop using so-called "hybrid approach" when implementation tries to determine in runtime what NSDateFormatter instance to use: the shared one or retrieved from thread dictionary. Now a library user must decide if thread-safe but more expensive behaviour is desired (default) or simple storing date formatter in ivar is sufficient (suitable for using formatter with a single logger).
…ride point to configure used NSDateFormatter.
| Class cls = [self class]; | ||
| SEL configMethodName = @selector(configureDateFormatter:); | ||
| Method configMethod = class_getInstanceMethod(cls, configMethodName); | ||
| for (;;) { |
There was a problem hiding this comment.
Probably while (YES) may be better. Nor sure if do can be used.
There was a problem hiding this comment.
I'll rewrite using while with non-trivial condition and without break-s
…ueueLogFormatterMode` enum.
…ctive implementation of `configureDateFormatter:` Even seems more readable now.
|
@erysaj I think your implementation looks strong, so I will go ahead and merge it. We will keep an eye on this. |
bpoplauschi
added a commit
that referenced
this pull request
Oct 21, 2015
Fix NSDateFormatter issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to solve crashes in NSDateFormatter still observed in the wild.
Stop using so-called "hybrid approach" when implementation tries to determine in runtime what NSDateFormatter instance to use: the shared one or retrieved from thread dictionary. Now a library user must decide if thread-safe but more expensive behaviour is desired (default) or simple storing date formatter in ivar is sufficient (suitable for using formatter with a single logger).
A few more minor tweaks: