Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed nullability of DDExtractFileNameWithoutExtension() function. #845

Merged
merged 2 commits into from Mar 4, 2017

Conversation

jcbertin
Copy link
Contributor

@jcbertin jcbertin commented Mar 4, 2017

New Pull Request Checklist

  • I have read and understood the CONTRIBUTING guide

  • I have read the Documentation

  • I have searched for a similar pull request in the project and found none

  • I have updated this branch with the latest master to avoid conflicts (via merge from master or rebase)

  • I have added the required tests to prove the fix/feature I am adding

  • I have updated the documentation (if necesarry)

  • I have run the tests and they pass

  • I have run the lint and it passes (pod lib lint)

This merge request fixes / reffers to the following issues: ...

Pull Request Description

I fixed the signature of DDExtractFileNameWithoutExtension() function since it can returns null values if filePath parameter is null or if -[NSString initWithBytes:] fails.
I also renamed LOG_MAX_QUEUE_SIZE to DDLOG_MAX_QUEUE_SIZE and make it optional. It will not break existing code since this macro is private (see Discussion #839).

@codecov-io
Copy link

Codecov Report

Merging #845 into master will not change coverage.
The diff coverage is 80%.

@@           Coverage Diff           @@
##           master     #845   +/-   ##
=======================================
  Coverage   23.07%   23.07%           
=======================================
  Files          16       16           
  Lines        3913     3913           
  Branches      279      279           
=======================================
  Hits          903      903           
  Misses       3008     3008           
  Partials        2        2
Impacted Files Coverage Δ
Classes/DDLog.h 88.23% <ø> (ø)
Classes/DDLog.m 57.18% <80%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 293994c...0f9efc2. Read the comment docs.

@rivera-ernesto rivera-ernesto merged commit 7ae144f into CocoaLumberjack:master Mar 4, 2017
@bpoplauschi bpoplauschi added this to the 3.2.0 milestone May 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants