Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Xcode to 8.2 and set SWIFT_VERSION to 3.0 #853

Merged
merged 2 commits into from Mar 13, 2017
Merged

Bump Xcode to 8.2 and set SWIFT_VERSION to 3.0 #853

merged 2 commits into from Mar 13, 2017

Conversation

sushichop
Copy link
Member

New Pull Request Checklist

  • I have read and understood the CONTRIBUTING guide

  • I have read the Documentation

  • I have searched for a similar pull request in the project and found none

  • I have updated this branch with the latest master to avoid conflicts (via merge from master or rebase)

  • I have added the required tests to prove the fix/feature I am adding

  • I have updated the documentation (if necesarry)

  • I have run the tests and they pass

  • I have run the lint and it passes (pod lib lint)

This merge request reffers to the following issues: #848

Pull Request Description

Note
Unfortunately you had to set SWIFT_VERSION to 3.0.1 with Xcode 8.1 because of the bug with Xcode.
Now you can set SWIFT_VERSION to 3.0 again with Xcode 8.2 or later and 3.0 is definitely desired value.

@codecov-io
Copy link

Codecov Report

Merging #853 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #853   +/-   ##
=======================================
  Coverage   22.86%   22.86%           
=======================================
  Files          16       16           
  Lines        3902     3902           
  Branches      279      279           
=======================================
  Hits          892      892           
  Misses       3008     3008           
  Partials        2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5eac1a...723dccf. Read the comment docs.

@rivera-ernesto rivera-ernesto merged commit 640b108 into CocoaLumberjack:master Mar 13, 2017
@bpoplauschi bpoplauschi added this to the 3.2.0 milestone May 3, 2017
@sushichop sushichop deleted the xcode8.2-swift3.0 branch October 10, 2017 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants