Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extern "C" for Objective-C++ #922

Merged
merged 1 commit into from Apr 2, 2018
Merged

extern "C" for Objective-C++ #922

merged 1 commit into from Apr 2, 2018

Conversation

sushichop
Copy link
Member

@sushichop sushichop commented Apr 2, 2018

New Pull Request Checklist

  • I have read and understood the CONTRIBUTING guide

  • I have read the Documentation

  • I have searched for a similar pull request in the project and found none

  • I have updated this branch with the latest master to avoid conflicts (via merge from master or rebase)

  • I have added the required tests to prove the fix/feature I am adding

  • I have updated the documentation (if necessary)

  • I have run the tests and they pass

  • I have run the lint and it passes (pod lib lint)

This merge request fixes the following issues: #920 .
I confirmed that I was able to linked with THIS_FILE macro in both Objective-C++ file(.mm) and Objective-C file(.m).

@codecov-io
Copy link

Codecov Report

Merging #922 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #922   +/-   ##
=======================================
  Coverage   21.56%   21.56%           
=======================================
  Files          14       14           
  Lines        3358     3358           
  Branches       43       43           
=======================================
  Hits          724      724           
  Misses       2628     2628           
  Partials        6        6

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3298738...e6be1bb. Read the comment docs.

@bpoplauschi bpoplauschi merged commit 65b84ab into CocoaLumberjack:master Apr 2, 2018
@sushichop sushichop deleted the PR/macro-for-objcpp branch April 16, 2018 15:17
@bpoplauschi bpoplauschi added this to the 3.4.2 milestone Apr 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants