Merge pull request #63 from CocoaPods/seg-argument-suggester-question

[ArgumentSuggester] Add a question mark after did you mean
CocoaPods · Mar 10, 2016 · d9c7016 · d9c7016
2 parents 46c7f6e + 40dceff
commit d9c7016
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 6 deletions.
diff --git a/lib/claide/command/argument_suggester.rb b/lib/claide/command/argument_suggester.rb
@@ -45,7 +45,7 @@ def suggestion
           pretty_suggestion = self.class.prettify_suggestion(suggestion,
                                                              @argument_type)
           "Unknown #{argument_description}: `#{@argument}`\n" \
-            "Did you mean: #{pretty_suggestion}"
+            "Did you mean: #{pretty_suggestion}?"
         else
           "Unknown #{argument_description}: `#{@argument}`"
         end
@@ -64,7 +64,7 @@ def suggestion
       def self.prettify_suggestion(suggestion, argument_type)
         case argument_type
         when :option, :flag
-          suggestion = "#{suggestion}"
+          suggestion = suggestion.to_s
           suggestion.ansi.blue
         when :arg
           suggestion.ansi.green

diff --git a/spec/command/argument_suggester_spec.rb b/spec/command/argument_suggester_spec.rb
@@ -32,7 +32,8 @@ class CLAide::Command
     describe '#suggestion' do
       it 'returns the message for a command' do
         result = ArgumentSuggester.new('spec_file', Fixture::Command).suggestion
-        result.should == "Unknown command: `spec_file`\nDid you mean: spec-file"
+        result.
+          should == "Unknown command: `spec_file`\nDid you mean: spec-file?"
       end
 
       it 'returns the message for when no suggestion is possible' do
@@ -43,7 +44,7 @@ class CLAide::Command
 
       it 'returns the message for an option' do
         result = ArgumentSuggester.new('--verbosa', Fixture::Command).suggestion
-        result.should == "Unknown option: `--verbosa`\nDid you mean: --verbose"
+        result.should == "Unknown option: `--verbosa`\nDid you mean: --verbose?"
       end
     end
   end

diff --git a/spec/command_spec.rb b/spec/command_spec.rb
@@ -153,12 +153,12 @@ module CLAide
       end
 
       it 'raises a Help exception when created with an invalid subcommand' do
-        message = "Unknown command: `unknown`\nDid you mean: spec-file"
+        message = "Unknown command: `unknown`\nDid you mean: spec-file?"
         should_raise_help message do
           @command.parse(%w(unknown)).validate!
         end
 
-        should_raise_help "Unknown command: `unknown`\nDid you mean: lint" do
+        should_raise_help "Unknown command: `unknown`\nDid you mean: lint?" do
           @command.parse(%w(spec-file unknown)).validate!
         end
       end