Rakefile should not try to install bundler

[AliSoftware]

The bootstrap task should not install bundler (see this line). Instead, we should check if bundler is not installed and ask the user to install it manually.

See CocoaPods/Rainforest#13

---

Inspiration:

task :bootstrap do
  if system('which bundler')
    ...
  else
    puts red("\nPlease install bundler manually")
    puts "$ [sudo] gem install bundler"
  end
end

[alloy]

By the way, I now realise that that check is wrong as well. The real binary is called bundle not bundler. The bundler binary was added recently for people that mistype it: rubygems/bundler@e73084e.

[AliSoftware]

@alloy btw shouldn't we also use hash instead of which?

[AliSoftware]

Template syntax to use for reference: https://gist.github.com/alloy/f0292ff380647028e9b1

[alloy]

@alloy btw shouldn't we also use hash instead of which?

Why? Using which has been working fine for me the last ~10 years :)

[AliSoftware]

I believe hash is faster (being a hash table and all whereas which has to go thru all the directories in $PATH)… but maybe it only exists in sh. And the speed benefit is probably not worth it.

Tbh, I quite never used hash myself, being used to use which like you do, but as i came across hash again lately, I was just wondering.

[AliSoftware]

CheckList for applying this fix to all repositories in the Rainforest.

• Rainforest (see diff)
• CLAide (see diff)
• CocoaPods (see diff)
• Core (see diff)
• VersionKit (see diff)
• Xcodeproj (see diff)
• cocoapods-docs (see PR) ⚠️ push access welcome
• cocoapods-downloader (see diff)
• cocoapods-plugins (see diff)
• cocoapods-podfile_info (see diff)
• cocoapods-try (see diff)
• pod-template (not concerned)
• shared (see diff)

[AliSoftware]

All done, but as it was repetitive tasks and I did this at 3-4 AM, code review on all those Rakefiles would be very welcome 😉

And there is the PR CocoaPods/cocoapods-docs#2 to accept too, as I don't have push access to this one (I wonder why).

[alloy]

@AliSoftware It all looks good to me! Have you tried to perform a clean bootstrap after applying all these changes?

[alloy]

@AliSoftware I’m also thinking that we could possible run this on Travis to ensure that bootstrapping in a clean env works. Any idea how long a bootstrap takes on average?

[AliSoftware]

I did remove my Rainforest clone, then clone it again and bootstraped, and everything seemed to work fine for me.

I didn't watch how long it took however.

[alloy]

If it doesn't take too long it would be nice to ensure (possible) new collars are ensured to get a working env.

[AliSoftware]

I propose that we close this issue, and open a new one for that "Travis should test bootstrap task" issue.

Question: where to open such ticket? In CocoaPods/shared maybe, as it is where the template .travis.yml to used for all templates should be stored? Or in CocoaPods/Rainforest, as it will be an issue similar to CocoaPods/Rainforest#12 and will need a task in Rainforest's Rakefile to update all other repos from shared?)

[fabiopelosin]

I would test the bootstrap task in Rainforest as well.

Awesome work!