Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The Analyzer should store inspected build setting per build configuration name #1466

Closed
fabiopelosin opened this issue Oct 10, 2013 · 5 comments
Closed

The Analyzer should store inspected build setting per build configuration name #1466

fabiopelosin opened this issue Oct 10, 2013 · 5 comments
Labels
d2:moderate A moderately-difficult ticket that may require a bit of knowledge about the codebase s2:confirmed Issues that have been confirmed by a CocoaPods contributor t2:defect These are known bugs. The issue should also contain steps to reproduce. PRs welcome!

Comments

@fabiopelosin
Copy link
Member

Currently the analyzer, while computing the build setting which should be inherited from the user target, resolves and stores a single value for all the build configurations. This approach is not robust as build setting might differ.

Related: #1462
@CocoaPodsBot
Copy link

Issue has been confirmed by @neonichu

@kylef
Copy link
Contributor

kylef commented Sep 14, 2014

@fabiopelosin Has this been resolved?

@fabiopelosin
Copy link
Member Author

I don't think.

@segiddins segiddins added the d2:moderate A moderately-difficult ticket that may require a bit of knowledge about the codebase label Oct 5, 2015
@segiddins
Copy link
Member

@mrackwitz is there any point in keeping this issue open? I think the target inspector is plenty robust after your latest refactor.

@mrackwitz
Copy link
Member

My latest changes around the analyzer / target inspector didn't really improved anything around that.
But it seems that Xcodeproj's methods to resolve common build settings became just more robust. If any build setting has multiple values, then it will raise an exception.
I don't think we can or want to do anything about that as it would mean a drastic increase of complexity if we would take different platforms or architectures per build configuration into account.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
d2:moderate A moderately-difficult ticket that may require a bit of knowledge about the codebase s2:confirmed Issues that have been confirmed by a CocoaPods contributor t2:defect These are known bugs. The issue should also contain steps to reproduce. PRs welcome!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@kylef @fabiopelosin @mrackwitz @segiddins @CocoaPodsBot